[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml/misc
From:       Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date:       2004-02-03 23:44:30
Message-ID: 200402040044.38320 () erwin ! ingo-kloecker ! de
[Download RAW message or body]


On Tuesday 03 February 2004 13:36, Kazuki Ohta wrote:
> CVS commit by kzk:
>
> This is the more enhanced version of Japanese encoding detection
> code.
>
> The original one cannot detect UTF-8 correctly, so I improved this
> and now, KHTML can detect it.
>
> This routine(guess_jp) is derived from the one which is used in
> Gauche, the Scheme interpreter, and it is BSD licensed(so I include
> the copyright). I contacted Takumi Asaki(asaki@kde.gr.jp), who is the
> author of original code, and he said OK to commit this code.

Is it actually possible to mix two licenses in the same file? Even if it 
was possible then those parts of the file which are BSD licensed must 
be clearly marked as such and must be clearly separated from the LGPL 
licensed code. I suggest to put the BSD licensed code into a cpp file 
of its own. The code should be pretty much self-contained.

Apart from that I'd like to point out the following:
=====
2. Redistributions in binary form must reproduce the above copyright
 notice, this list of conditions and the following disclaimer in the
 documentation and/or other materials provided with the distribution.
=====

I guess the copyright notice will have to be added to the API 
documentation.

Regards,
Ingo

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]