[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kicker/buttons
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2004-01-25 16:00:54
Message-ID: A7A7C752-4F4F-11D8-882D-003065674F82 () kde ! org
[Download RAW message or body]

On Jan 24, 2004, at 7:43 PM, Matt Rogers wrote:
> On Saturday 24 January 2004 02:26 pm, Allan Sandfeld Jensen wrote:
>> CVS commit by carewolf:
>>
>> Prevent(or hide) kicker from shortly freezing when launching 
>> applications.
>>
>>
>>   M +1 -0      servicebutton.cpp   1.19
>>
>>
>> --- kdebase/kicker/buttons/servicebutton.cpp  #1.18:1.19
>> @@ -200,4 +200,5 @@ void ServiceButton::slotExec()
>>
>>      KURL::List uriList;
>> +    kapp->processEvents(20);
>>      kapp->propagateSessionManager();
>>      KRun::run( *_service, uriList );
>
> granted, I don't know the kicker code at all, but perhaps there's a 
> better way
> to do this other than using a processEvents()  hack?

I don't like it either -- it's very likely to result in crashes in some 
piece of code that doesn't expect to be reentered. Please revert, and 
find a better way.

-John

[prev in list] [next in list] [prev in thread] [next in thread]