[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenetwork/knewsticker
From:       Frerich Raabe <raabe () kde ! org>
Date:       2004-01-22 13:39:46
Message-ID: 20040122133946.235482A6E () office ! kde ! org
[Download RAW message or body]

CVS commit by raabe: 

- Don't crash when selecting articles in a newsfeed which comes after a
  newsfeed which couldn't get retrieved.
CCMAIL:69874-done@bugs.kde.org
CCMAIL:71920-done@bugs.kde.org
CCMAIL:72127-done@bugs.kde.org


  M +10 -1     knewsticker.cpp   1.166


--- kdenetwork/knewsticker/knewsticker.cpp  #1.165:1.166
@@ -514,6 +514,15 @@ void KNewsTickerMenu::slotOpenArticle(in
         const NewsSourceBase::List sources = m_parent->m_newsSources;
         NewsSourceBase::List::ConstIterator it = sources.begin();
-        while ( it != sources.end() && ( *it )->articles().count() - 1 < i ) {
+        while ( it != sources.end() ) t{
+                if ( ( *it )->articles().isEmpty() ) {
+                        ++it;
+                        continue;
+                }
+
+                if ( i <= ( *it )->articles().count() - 1 )
+                        break;
+
                 i -= ( *it )->articles().count();
+
                 ++it;
         }


[prev in list] [next in list] [prev in thread] [next in thread]