[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdepim/kmail
From:       Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date:       2004-01-20 12:28:10
Message-ID: 20040120122810.780511A27 () office ! kde ! org
[Download RAW message or body]

CVS commit by mutz: 

from aegypten_branch:

Refactor partNode creation from a KMMessage into a static method on partNode and port \
users to it. In the process of this, I found out that KMMessage, \
KMSaveAttachmentCommand and KMReaderWin all used very slightly different methods to \
instantiate the root item. I think most of them were wrong:

KMMessage's way (originally spread over two methods...) leaks mainBody...
KMReaderWins' way adds firstBodyPart as a child of itself...
KMSaveAttachmentsCommand doesn't adjust the mimetypes.

So that's why this is experimental: I've combined the various ways with majority \
vote: two adjusted the mimetypes, so mimetypes are adjusted. Only one added a part as \
child of it's own, so that's no longer being done, etc.

--and--

Replace broken, complicated logic with clean and simple one. Parsing is cheap in \
mimelib. That gives us the full MIME headers also in the top-level container \
partNode, which is needed in ae_branch to get at the protocol-Parameter of mp/signed \
parts...


  M +3 -33     kmcommands.cpp   1.102
  M +6 -36     kmmessage.cpp   1.453
  M +3 -2      kmmessage.h   1.159
  M +9 -64     kmreaderwin.cpp   1.735
  M +28 -0     partNode.cpp   1.42
  M +3 -1      partNode.h   1.31


[prev in list] [next in list] [prev in thread] [next in thread]