[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [PATCH] kpty weirdness (was: Re: kdelibs/kdecore)
From:       Andy Fawcett <andy () athame ! co ! uk>
Date:       2004-01-13 21:58:05
Message-ID: 200401132358.05895.andy () athame ! co ! uk
[Download RAW message or body]

[adding kde-cvs back, I missed that earlier]

On Tuesday 13 January 2004 21:03, Andy Fawcett wrote:
> On Tuesday 13 January 2004 20:37, Oswald Buddenhagen wrote:
> > On Mon, Jan 12, 2004 at 07:38:01PM +0200, Andy Fawcett wrote:
> > > On Monday 12 January 2004 18:23, Oswald Buddenhagen wrote:
> > > > On Mon, Jan 12, 2004 at 06:17:02PM +0200, Andy Fawcett wrote:
> > > > > On Saturday 10 January 2004 20:35, Oswald Buddenhagen wrote:
> > > > > > CVS commit by ossi:
> > > > > >
> > > > > > trying to fix #67464 by not trying to chownpty if everything
> > > > > > is ok already. some cleanup as well. ok'd by waldo.
> > > > > >
> > > > > >
> > > > > >   M +69 -75    kpty.cpp   1.15
> > > > >
> > > > > This change prevents konsole from starting on FreeBSD.
> > > >
> > > > this stuff is weird ...
> > >
> > > Yes.
> >
> > and here is yet another attempt at fixing this stuff. the patch
> > changes quite a lot of details, so i decided to adhere to the commit
> > policy and post it. :) please review not only the patch, but also the
> > explainations below.
>
> [...]
>
> > - entirely remove the openpty() part. it is redundand: it is only a
> > neat encapsulation of all the code below, so one of the two can go
> > away. as for some (to me) absolutely incomprehensible reasons the
> > openpty() based variant causes total failure on tap's freebsd setup,
> > the choice is simple. :)
>
> I can confirm the patch _seems_ to fix the problems for me on FreeBSD
> 5.2, but for the last few hours of messing around with it I've yet to
> have a failure. (famous last words)
>
> I haven't had time to build/test on FreeBSD 4.9 which is the -STABLE
> branch and therefore still widely used. There were large changes
> between 4.x and 5.x, so I don't know if this patch will fix things
> there (or even if the recent changes _affected_ 4.x!)
>
> If somebody can verify on FreeBSD 4.x, it would be good. Of course,
> other platforms will need checking too.

Will Andrews has confirmed that the patch is okay on 4.x, and Adriaan has 
confirmed it is ok on 5.2/AMD64, so as far as FreeBSD is concerned we like 
the patch.

Cheers Ossi

A.


-- 
Andy Fawcett                                     | andy@athame.co.uk
                                                 | tap@kde.org
"In an open world without walls and fences,      | tap@lspace.org
  we wouldn't need Windows and Gates."  -- anon  | tap@fruitsalad.org
[prev in list] [next in list] [prev in thread] [next in thread]