[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kwallet/client
From:       Waldo Bastian <bastian () kde ! org>
Date:       2004-01-07 21:03:11
Message-ID: 200401072203.12439.bastian () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Is konqueror able to handle the reentrancy that this creates?

I have been giving this some thought and I think the only reliable solution is 
to make this asynchronous with async-dcop-calls. Such calls make a callback 
to a slot when the call is finished.

Cheers,
Waldo

On Wed January 07 2004 19:42, George Staikos wrote:
> CVS commit by staikos:
>
> I guess I have to revert it myself.  I think your problems lie elsewhere. 
> This commit prevents konqueror from locking up when kwallet is accessed.
>
>
>   M +8 -1      kwallet.cc   1.43
>
>
> --- kdelibs/kwallet/client/kwallet.cc  #1.42:1.43
> @@ -169,4 +169,11 @@ Wallet *Wallet::openWallet(const QString
>          DCOPReply r;
>
> +#if KDE_IS_VERSION(3,1,90)
> +        if (isPath) {
> +                r = DCOPRef("kded", "kwalletd").callExt("openPath",
> DCOPRef::UseEventLoop, -1, name, uint(w)); +        } else {
> +                r = DCOPRef("kded", "kwalletd").callExt("open",
> DCOPRef::UseEventLoop, -1, name, uint(w)); +        }
> +#else
>          if (isPath) {
>                  r = DCOPRef("kded", "kwalletd").call("openPath", name,
> uint(w)); @@ -174,5 +181,5 @@ Wallet *Wallet::openWallet(const QString
>                  r = DCOPRef("kded", "kwalletd").call("open", name,
> uint(w)); }
> -
> +#endif
>          if (r.isValid()) {
>                  int drc = -1;

- -- 
bastian@kde.org -=|[ KDE: K Desktop for the Enterprise ]|=- bastian@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE//HQPN4pvrENfboIRAiQbAJ4n/jJan0bQkYAwSI/1WAhw4+wPMwCePv6N
qM89xTPzklM6ozGMKHfV+O8=
=if5f
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]