[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KOFFICE_1_3_BRANCH: koffice/filters/kword/rtf/import
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2003-12-18 21:21:18
[Download RAW message or body]

Well, sorry, perhaps I have overacted a little.

But I am tired of I-know-better-than-the-developers types of commits and in 
your commit I only saw comments removed and some "politically correct" 
changes. I did not find anything that would fit the description. (And yes, 
someone has already tried to add something else than what he had put in the 
commit description. That is perhaps why I was "allergic". Sorry again.)

So, even if I cannot reproduce your problem, it is a serious one nevertheless, 
and one that has a much easier fix: remove one of the ambigious functions. 
(As we need to make a QString out of the parameters, the char* function is 
superfluous.)

So that is what I have done for CHS HEAD, while reverting your changes. I plan 
to do it for KOFFICE_1_3_BRANCH too (when I will be able to test it.)

Just one word about "obviousness": personally I had to learn that "fixing" a 
problem by casting (or similar) is rarely a good solution. Mostly the real 
problem is still there and might even be cloacked by the "fix". And of course 
the problem will probably reappear sometimes later (and according to Murphy's 
Law, at a time point when you absolutely do not need it.)

Have a nice day!

--- Original Message ---
List:     kde-cvs
Subject:  Re: KOFFICE_1_3_BRANCH: koffice/filters/kword/rtf/import
From:     Adrian Schroeter <adrian () suse ! de>
Date:     2003-12-18 19:33:47


On Thu, 18 Dec 2003, Nicolas Goutte wrote:
> Can you please expalin, especially why to break the deep freeze of KOffice 
> 1.3.x for such a commit?

koffice did not compile for any suse distro with current Qt packages 
(Qt 3.2.3), together with gcc 3.2, 3.2-hammer-branch or 3.3

It failed with errors, like this one, so I needed to apply for the 
packages (and I thought you want to have this fixed also. Sorry for not 
letting review before, but it looke so obviously right for me)
 
rtfimport_dom.cpp:173: error: call of overloaded `setAttribute(const 
char[9],
   QString)' is ambiguous
rtfimport_dom.h:40: error: candidates are: void 
DomNode::setAttribute(const
   char*, const char*)
rtfimport_dom.h:41: error:                 void 
DomNode::setAttribute(const
   QString&, const QString&)



bye
adrian

(...)

[prev in list] [next in list] [prev in thread] [next in thread]