[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kwallet/client
From:       Christian Loose <christian.loose () hamburg ! de>
Date:       2003-12-18 14:34:43
[Download RAW message or body]

Am Donnerstag, 18. Dezember 2003 02:46 schrieb Alexander Kellett:
> On Thu, Dec 18, 2003 at 01:50:03AM +0100, Friedrich W. H.  Kossebau wrote:
> > Am Mittwoch, 17. Dezember 2003 23:23 schrieb George Staikos:
> > > On Wednesday 17 December 2003 17:02, Volker Krause wrote:
> > > > CVS commit by vkrause:
> > > >
> > > > Fix a typo in folderDoesNotExist() causing it to always return true.
> > > >
> > > > Fixes #70425.
> > > > --- kdelibs/kwallet/client/kwallet.cc  #1.40:1.41
> > > > @@ -618,5 +618,5 @@ void Wallet::walletOpenResult(int id) {
> > > >
> > > >  bool Wallet::folderDoesNotExist(const QString& wallet, const
> > > > QString& folder) { -DCOPReply r = DCOPRef("kded",
> > > > "kwalletd").call("fodlerDoesNotExist", wallet, folder); +DCOPReply r
> > > > = DCOPRef("kded", "kwalletd").call("folderDoesNotExist", wallet,
> > > > folder); bool rc = true;
> > >
> > >   Wow nice catch!  Thanks!
> >
> > Those mistakes make me wonder why noone seems to use
> > #define SomeIDString "important"
> > or
> > static const char const* SomeIDString = "Important";
> >
> > Is there any reason for this?
>
> or even better why not have dcopidl2cpp itself create these .h's
>
> Alex

It actually already does something similar. You can let dcopidl2cpp create a 
DCOPStub. Then you have a class that does all the ugly stuff of calling a 
DCOP method. So instead of writing

DCOPRef("kded", "kwalletd").call("folderDoesNotExist", wallet, folder);

you do

Backend_stub("kded", "kwalletd").folderDoesNotExist(wallet, folder);

and the compiler checks for you if you have a typo.

Christian

[prev in list] [next in list] [prev in thread] [next in thread]