From kde-commits Thu Dec 18 01:46:59 2003 From: Alexander Kellett Date: Thu, 18 Dec 2003 01:46:59 +0000 To: kde-commits Subject: Re: kdelibs/kwallet/client X-MARC-Message: https://marc.info/?l=kde-commits&m=107171181122652 On Thu, Dec 18, 2003 at 01:50:03AM +0100, Friedrich W. H. Kossebau wrote: > Am Mittwoch, 17. Dezember 2003 23:23 schrieb George Staikos: > > On Wednesday 17 December 2003 17:02, Volker Krause wrote: > > > CVS commit by vkrause: > > > > > > Fix a typo in folderDoesNotExist() causing it to always return true. > > > > > > Fixes #70425. > > > --- kdelibs/kwallet/client/kwallet.cc #1.40:1.41 > > > @@ -618,5 +618,5 @@ void Wallet::walletOpenResult(int id) { > > > > > > bool Wallet::folderDoesNotExist(const QString& wallet, const QString& > > > folder) { -DCOPReply r = DCOPRef("kded", > > > "kwalletd").call("fodlerDoesNotExist", wallet, folder); +DCOPReply r = > > > DCOPRef("kded", "kwalletd").call("folderDoesNotExist", wallet, folder); > > > bool rc = true; > > > > Wow nice catch! Thanks! > > Those mistakes make me wonder why noone seems to use > #define SomeIDString "important" > or > static const char const* SomeIDString = "Important"; > > Is there any reason for this? or even better why not have dcopidl2cpp itself create these .h's Alex