[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kfind
From:       Waldo Bastian <bastian () kde ! org>
Date:       2003-12-10 12:00:08
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This looks like a very bad hack. Better ask KDirWatch which update method is 
used. Has this been reviewed by anyone?

Cheers,
Waldo

On Wed December 10 2003 12:48, Eric Coquelle wrote:
> CVS commit by coquelle:
>
> Fixed bug #69449: without libfam, the update of kfind's search results is
> too slow (may take several seconds before the search begins if there's a
> large number of subdirectories in the search dir.)
>
>
>   M +8 -2      kfinddlg.cpp   1.19
>   M +1 -0      kfinddlg.h   1.8
>   M +1 -1      kfindpart.h   1.9
>
>
> --- kdebase/kfind/kfinddlg.cpp  #1.18:1.19
> @@ -15,4 +15,5 @@
>  #include <kdebug.h>
>  #include <kaboutapplication.h>
> +#include <kstandarddirs.h>
>
>  #include "kftabdlg.h"
> @@ -87,4 +88,9 @@ KfindDlg::KfindDlg(const KURL & url, QWi
>    connect(query, SIGNAL(result(int)), SLOT(slotResult(int)));
>    aboutWin = new KAboutApplication(this, "about", true);
> +
> +  //Disable the search results update if one hasn't FAM
> +  KStandardDirs dirs;
> +  dirs.addPrefix("/usr");
> +  has_libfam=!dirs.findResource("lib","libfam.so").isNull();
>    dirwatch=NULL;
>  }
> @@ -135,5 +141,5 @@ void KfindDlg::startSearch()
>
>    //Getting a list of all subdirs
> -  if(tabWidget->isSearchRecursive())
> +  if(tabWidget->isSearchRecursive() && has_libfam)
>    {
>      QStringList subdirs=getAllSubdirs(query->url().path());
>
> --- kdebase/kfind/kfinddlg.h  #1.7:1.8
> @@ -65,4 +65,5 @@ private:
>    KDirLister *dirlister;
>    KDirWatch *dirwatch;
> +  bool has_libfam;
>  };

- -- 
bastian@kde.org -=|[ KDE: K Desktop for the Enterprise ]|=- bastian@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/1wrIN4pvrENfboIRAlxTAKCQW+coOu3b3/sABUcgFQZJsJTprACff9iQ
7gXqcI1WHQvs3JdHh6qQ8uI=
=XEzL
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]