[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdeextragear-2/taglib
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2003-12-01 1:20:42
[Download RAW message or body]

CVS commit by wheeler: 

API nitpicks suggested by Frerich --

*) Mark the first FileRef constructor as explicit
*) Add an operator!=()


  M +5 -0      fileref.cpp   1.12
  M +12 -3     fileref.h   1.11


--- kdeextragear-2/taglib/fileref.cpp  #1.11:1.12
@@ -109,4 +109,9 @@ bool FileRef::operator==(const FileRef &
 }
 
+bool FileRef::operator!=(const FileRef &ref) const
+{
+  return ref.d->file != d->file;
+}
+
 File *FileRef::create(const char *fileName, bool readAudioProperties,
                       AudioProperties::ReadStyle audioPropertiesStyle) // static

--- kdeextragear-2/taglib/fileref.h  #1.10:1.11
@@ -79,6 +79,8 @@ namespace TagLib {
      * use this method in your application.
      */
-    FileRef(const char *fileName, bool readAudioProperties = true,
-            AudioProperties::ReadStyle audioPropertiesStyle = AudioProperties::Average);
+    explicit FileRef(const char *fileName,
+                     bool readAudioProperties = true,
+                     AudioProperties::ReadStyle
+                     audioPropertiesStyle = AudioProperties::Average);
 
     /*!
@@ -152,4 +154,10 @@ namespace TagLib {
 
     /*!
+     * Returns true if this FileRef and \a ref do not point to the same File
+     * object.
+     */
+    bool operator!=(const FileRef &ref) const;
+
+    /*!
      * A simple implementation of file type guessing.  If \a readAudioProperties
      * is true then the audio properties will be read using
@@ -160,5 +168,6 @@ namespace TagLib {
      * directly.
      */
-    static File *create(const char *fileName, bool readAudioProperties = true,
+    static File *create(const char *fileName,
+                        bool readAudioProperties = true,
                         AudioProperties::ReadStyle audioPropertiesStyle = AudioProperties::Average);
 


[prev in list] [next in list] [prev in thread] [next in thread]