[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenetwork/kopete/libkopete
From:       Jason Keirstead <jason () keirstead ! org>
Date:       2003-11-10 16:02:10
[Download RAW message or body]

On November 10, 2003 11:51 am, Matt Rogers wrote:
> CVS commit by mattr: 
> 
> Fix bug 67676 by disallowing chats to the myself() contact, which is the
> way it should be. Why would you want to chat with yourself anyways? ;)
> 

Actually I don't think this should be in here. I /query myself on IRC all the 
time to test things. Just because OSCAR doesn't have the capability doesn't 
mean you need to exclude it from all protocols. The checking should be done 
in OSCAR.

That aside, this patch doesn't prevent you from chatting youself anyways, it 
only prevents you from doing so via the left click.

 If someone right clicks on the contact and chooses "Start Chat" on themselves 
in ICQ, it's still going to crash because it doesn't call execute()

-- 
There's no place like 127.0.0.1

http://www.keirstead.org
[prev in list] [next in list] [prev in thread] [next in thread]