[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kicker/taskmanager
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2003-11-06 9:25:38
[Download RAW message or body]

On Wednesday 05 of November 2003 19:04, Frerich Raabe wrote:
> CVS commit by raabe:
>
> - Don't use deprecated methods

 You haven't really tested this, have you? The taskbar is not a normal 
application and falls in the special case 'pagers and similar tools, which 
represent direct user actions related to window manipulation'. Maybe I got 
the API naming wrong :-/, as you're not the first one getting it wrong.

>
>
>   M +4 -4      taskmanager.cpp   1.70
>
>
> --- kdebase/kicker/taskmanager/taskmanager.cpp  #1.69:1.70
> @@ -616,5 +616,5 @@ void Task::maximize()
>      ni.setState( NET::Max, NET::Max );
>      if( !on_current )
> -        KWin::setActiveWindow( _win );
> +        KWin::activateWindow( _win );
>  }
>
> @@ -630,5 +630,5 @@ void Task::restore()
>      ni.setState( 0, NET::Max );
>      if( !on_current )
> -        KWin::setActiveWindow( _win );
> +        KWin::activateWindow( _win );
>  }
>
> @@ -683,5 +683,5 @@ void Task::toDesktop(int desk)
>          if (_info.onAllDesktops()) {
>              ni.setDesktop(kwin_module->currentDesktop());
> -            KWin::setActiveWindow(_win);
> +            KWin::activateWindow(_win);
>          }
>          else
> @@ -691,5 +691,5 @@ void Task::toDesktop(int desk)
>      ni.setDesktop(desk);
>      if(desk == kwin_module->currentDesktop())
> -        KWin::setActiveWindow(_win);
> +        KWin::activateWindow(_win);
>  }

-- 
 Lubos Lunak
 l.lunak@suse.cz     l.lunak@kde.org

[prev in list] [next in list] [prev in thread] [next in thread]