[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    qt-copy/src/kernel
From:       Ingo Klöcker <kloecker () kde ! org>
Date:       2003-10-24 16:01:51
[Download RAW message or body]

CVS commit by kloecker: 

Don't wrap long URLs in KMail and other apps using the Qt text editor classes. Patch by Lars Knoll.

----------  Forwarded Message  ----------

Subject: Re: [Issue N32570] [Qt 3.2.x Regression] Text wrap madness
Date: Monday 20 October 2003 13:42
From: qt-bugs@trolltech.com
To: Ingo Klöcker <kloecker@kde.org>
Cc: qt-bugs@trolltech.com

On Thursday, 16. Oct 2003 11:13 Ingo Klöcker wrote:
> On Wednesday 15 October 2003 20:15, Martijn Klingens wrote:
> > On Wednesday 15 October 2003 18:12, Ingo Klöcker wrote:
> > > The solution is obviously not to break after '/'. If someone
> > > writes
> > > two/ three he can easily add a space after the '/' in case he
> > > wants
> > > a line break after the '/'. In fact that's what I've been doing
> > > all
> > > the time. If OTOH Qt breaks after '/' then there's nothing the
> > > user
> > > can do to prevent this (unless he completely disables
> > > wordwrapping).
> >
> > That breaks the automatic formatting though. If you remove text in
> > that paragraph (causing a reformat) you'd end up with an unwanted
> > (and typographically incorrect) space.
>
> Of course, I anticipated this (absolutely correct) reply. ;-)
>
> [snip]
>
> > In other words, the best would be the text wrapping recognizing
> > URLs and adjusting its behaviour.
>
> I agree. But I didn't propose this because AFAIU the implementation
> it's
> completely agnostic about the context. So the only solution I can see
> is a OnlyBreakAtWhiteSpace mode (which is basically what Marc
> requested).

After thinking about it once again, I think the best is to revert to
3.1.x behaviour for slashes. I might reevaluate the whole thing for
Qt4, but before that, we're probably better off like this.

Lars

--
Lars Knoll, Senior Software Engineer
Trolltech AS, Waldemar Thranes gt. 98, N-0175 Oslo, Norway


  M +27 -9     qtextengine.cpp   1.6



[prev in list] [next in list] [prev in thread] [next in thread]