From kde-commits  Tue Sep 30 23:17:39 2003
From: Dirk Mueller <mueller () kde ! org>
Date: Tue, 30 Sep 2003 23:17:39 +0000
To: kde-commits
Subject: Re: kdelibs/khtml/ecma
X-MARC-Message: https://marc.info/?l=kde-commits&m=106500349005683

On Tuesday 30 September 2003 21:02, David Faure wrote:

> +
> +        // Update our document's rendering following the execution of the
> timeout callback. +        DOM::DocumentImpl *doc =
> static_cast<DOM::DocumentImpl*>(window->m_part->document().handle()); +    
>    doc->updateRendering();
>        }
>      }

This code misses null checks for window->m_part and document().handle() -> as 
this is called from a QTimer timeout this code is rather dangerous. 

BTW, it would be a lot cleaner to use Document::updateRendering() now that we 
have it. 


-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <