[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kcontrol
From:       Matthias Kretz <kretz () kde ! org>
Date:       2003-09-18 10:37:46
[Download RAW message or body]


Thanks, for fixing these KCMs. But still the problem remains that there might  
be other (third party) KCMs out there with the same problem, that's why I 
need to know what's breaking your KControl.

I did not break src compat, I kind of broke behaviour compat (and I tried to 
explain that before). Since I fixed both KCMultiDialog and ProxyWidget (and 
Lubos fixed KCDialog) this should be no issue.

I'll try to explain once more what's causing this:
KControl creates the KCM and only after that it can connect to the 
changed(bool) signal. If a KCM is broken and calls setChanged(true) in the 
ctor the changed(true) signal will not be emitted again until 
setChanged(false) and setChanged(true) is called. To fix this all classes 
using KCModule need to check for KCModule::changed() after the KCM ctor was 
called and enable/disable buttons accordingly.

Please note that KCMs still emitting the changed signal directly will behave 
exactly the same as before. I did a s/emit changed/setChanged/ in kdebase/
kcontrol, that's why they all broke in the same way.

On Thursday September 18 2003 10:44, George Staikos wrote:
> make half a dozen config modules work (or nearly work) again.
>
> Are you sure we haven't broken source compatibility?  Or did these just all
> happen to get broken in the same way?
>
>
> I have not tested many modules yet so it's likely that many more need to be
> repaired.

-- 
C'ya
        Matthias
________________________________________________________
Matthias Kretz (Germany)
http://Vir.homeip.net/
MatthiasKretz@gmx.net, kretz@kde.org

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]