[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdeui
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2003-09-17 16:10:11
[Download RAW message or body]

On Wednesday 17 September 2003 17:40, Nadeem Hasan wrote:
> Quoting Cornelius Schumacher <schumacher@kde.org>:
> > The purpose of the KInputDialog::getItem() function is to select an item,
> > not to show an item, so it seems to be much more appropriate to use a
> > widget which serves this purpose in the first place, not as an additional
> > functionality.
>
> Its function is to show the current selection, and let the user change it.
> Don't forget that it takes a value parameter too. Why do you think that is?

But within the context of the dialog showing the selection is only a secondary 
purpose. Of course the dialog needs a way to show the current selection, but 
opening a dialog to show the selection of one entry normally doesn't make 
much sense, because you can just as well put the selection directly in the 
GUI which calls the dialog and e.g. use a combo box instead of a button 
opening the dialog.

> > It's your personal preference to see a combo box. Seems we need somebody
> > else to decide whose arguments are better.
>
> I think as a maintainer of that class I have 2 votes, no?

Ok, counting Ians opinion it's 2:2 now.

> Other than that, is it your opinion that a combo box should always be
> replaced by a list box when its not editable? Then first go and change it
> everywhere else in KDE.

This isn't my opinion. My opinion is that in a dialog which contains only one 
combobox it's better to replace the combobox by a listbox. Unfortunately all 
places which have such dialogs use KInputDialog. So by changing it in 
KInputDialog I do exactly what you want: Changing it everywhere in KDE. If I 
missed a dialog please tell me where it is and I will happily change it as 
well.

-- 
Cornelius Schumacher <schumacher@kde.org>

[prev in list] [next in list] [prev in thread] [next in thread]