[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kcontrol/style
From:       Matthias Kretz <kretz () kde ! org>
Date:       2003-09-15 8:44:05
[Download RAW message or body]


Sorry George that I have to continue bothering you with this, but I would like 
to see all "emit KCModule::changed(bool)" calls gone from KDE CVS and if 
something does not work with that I need to fix it! I'd like to see your 
revert reverted :-) and then fix the real problem...

On Saturday September 13 2003 00:45, Matthias Kretz wrote:
> On Friday September 12 2003 04:45, George Staikos wrote:
> > On Thursday 11 September 2003 18:36, Matthias Kretz wrote:
> > > Why is the s/setChanged/emit changed/ needed? Please try to find out so
> > > that I may fix it. It definitely works here without that change...
> > > (What your change does is to tell KControl more than once that the
> > > module has changed. But KControl shouldn't need to be told twice or
> > > more, so there's a bug somewhere.)
> >
> >    I just backed out the patch you applied 08/31 IIRC.
>
> Yes, I've seen that.
>
> I just haven't understood how this fixes your problem. I guess I'm asking
> you to debug KControl. :-P
>
> >    Ah, only KControl is broken.
>
> And I fixed that problem with revision 1.56 of kcontrol/proxywidget.cpp (at
> least for me).

-- 
C'ya
        Matthias
________________________________________________________
Matthias Kretz (Germany)
http://Vir.homeip.net/
MatthiasKretz@gmx.net, kretz@kde.org

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]