[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kcontrol/style
From:       George Staikos <staikos () kde ! org>
Date:       2003-09-11 20:47:05
[Download RAW message or body]

On Thursday 11 September 2003 16:21, Matthias Kretz wrote:
> On Thursday September 11 2003 21:43, George Staikos wrote:
> > On Thursday 11 September 2003 15:38, Matthias Kretz wrote:
> > > The reason for the additional call in the save() method is, that after
> > > saving the apply button is disabled and only enabled again when the
> > > KCModule emits changed(true), and that can't happen if the module
> > > thinks it's changed already.
> >
> >   With that patch, Ok and Apply never get enabled no matter how many
> > options I change in that module.
>
> Is your kdebase/kcontrol/kcontrol up to date? The problem with that is,
> that the module calls setChanged(true) in the constructor (i.e. without
> user interaction). So the changed(true) signal could never be received. I
> changed KControl to work around that by checking the changed() method of
> KCModule and enabling the buttons for those broken modules.

  It was fairly close but not fully up to date, so I just updated again to be 
sure.  I still need that patch reverted for that module to work.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]