[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kcontrol/style
From:       George Staikos <staikos () kde ! org>
Date:       2003-09-11 19:43:55
[Download RAW message or body]

On Thursday 11 September 2003 15:38, Matthias Kretz wrote:
> On Thursday September 11 2003 19:07, George Staikos wrote:
> > I don't know what this was meant to do, but it makes the KCM unusable.
> > Revert last.
>
> I don't know what your problem is - it's working perfectly here.
>
> The reason for the changes is that emitting changed from the KCModule
> subclass is deprecated and you should use setChanged now instead.
>
> The reason for the additional call in the save() method is, that after
> saving the apply button is disabled and only enabled again when the
> KCModule emits changed(true), and that can't happen if the module thinks
> it's changed already.

  With that patch, Ok and Apply never get enabled no matter how many options I 
change in that module.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]