[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenetwork/knewsticker
From:       Frerich Raabe <raabe () kde ! org>
Date:       2003-09-08 20:14:26
[Download RAW message or body]

CVS commit by raabe: 

- I think this fixes the "not all newsfeeds get inserted when "Only scroll
  most recent headline" is inserted" problem, but I'm not sure. This sure
  makes more sense in any case - maybe Thomas can test this patch a bit?
  Everything except issue #1 should be fixed now (and that is trivial to change,
  too).
CCMAIL:62135@bugs.kde.org


  M +10 -13    knewsticker.cpp   1.163


--- kdenetwork/knewsticker/knewsticker.cpp  #1.162:1.163
@@ -182,12 +182,9 @@ void KNewsTicker::slotNewsSourceUpdated(
                 m_newNews = true;
 
-        NewsSourceBase::List::ConstIterator it = m_newsSources.begin();
-        NewsSourceBase::List::ConstIterator end = m_newsSources.end();
-        for (; it != end; ++it)
-                if (!(*it)->articles().isEmpty())
+        if (!ns->articles().isEmpty())
                         if (m_cfg->scrollMostRecentOnly())
-                                m_scroller->addHeadline((*it)->articles().first());
+                        m_scroller->addHeadline(ns->articles().first());
                         else {
-                                Article::List articles = (*it)->articles();
+                        Article::List articles = ns->articles();
                                 Article::List::ConstIterator artIt = articles.begin();
                                 Article::List::ConstIterator artEnd = articles.end();


[prev in list] [next in list] [prev in thread] [next in thread]