[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdesdk/kcachegrind/kcachegrind
From:       Laurent Montel <montel () kde ! org>
Date:       2003-09-01 7:52:19
[Download RAW message or body]

Le Sunday 31 August 2003 21:00, Josef Weidendorfer a écrit :
> Hi Laurent,

Hi,

> thanks for looking to improve KCachegrind.
>
> Unfortunately, your last commit broke it:
> You changed the signature of a virtual method in a base class,
> but forgot to change the signature for this method in subclasses, too.
> And this lead to an immediate crash on startup.

Oops sorry :(

> Please, could you at least check your changes by compiling and do
> a short run of the app before committing? I'm also quite fine with getting
> patches to supply them myself.

Ok I will make more test for the next commit.
Sorry again.

Regards.

> Thanks,
> Josef
[prev in list] [next in list] [prev in thread] [next in thread]