[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdesdk/kcachegrind/kcachegrind
From:       Matt Rogers <matt () matt ! rogers ! name>
Date:       2003-08-31 20:07:58
[Download RAW message or body]

On Sunday 31 August 2003 02:00 pm, Josef Weidendorfer wrote:
> Hi Laurent,
>
> thanks for looking to improve KCachegrind.
>
> Unfortunately, your last commit broke it:
> You changed the signature of a virtual method in a base class,
> but forgot to change the signature for this method in subclasses, too.
> And this lead to an immediate crash on startup.
>
> Please, could you at least check your changes by compiling and do
> a short run of the app before committing? I'm also quite fine with getting
> patches to supply them myself.
>
> Thanks,
> Josef

Ahh, so that's what was causing that. 
[prev in list] [next in list] [prev in thread] [next in thread]