[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenetwork/kopete/protocols/msn
From:       Martijn Klingens <klingens () kde ! org>
Date:       2003-08-30 1:03:39
[Download RAW message or body]

CVS commit by mklingens: 

Don't output passwords to the console in plain text!!!

If this is also in the 0.7 branch, please backport ASAP!

CCMAIL: kopete-devel@kde.org


  M +6 -4      msnnotifysocket.cpp   1.114


--- kdenetwork/kopete/protocols/msn/msnnotifysocket.cpp  #1.113:1.114
@@ -528,10 +528,12 @@ void MSNNotifySocket::slotAuthJobDone ( 
 
 
-                QString authURL="https://login.passport.com/ppsecure/post.srf?lc=" + \
                rx.cap(1) + "&id=" +rx.cap(2) +"&tw=" +rx.cap(3) +"&cbid=" + \
                rx.cap(2)
-                        + "&da=passport.com&login=" + m_account->accountId() + \
"&domain=passport.com&passwd=" + escape ( m_account->password() ) ; +                \
QString authURL = "https://login.passport.com/ppsecure/post.srf?lc=" + rx.cap( 1 ) + \
"&id=" + +                        rx.cap( 2 ) + "&tw=" + rx.cap( 3 ) + "&cbid=" + \
rx.cap( 2 ) + "&da=passport.com&login=" + +                        \
m_account->accountId() + "&domain=passport.com&passwd=";  
-                kdDebug(14140) << "MSNNotifySocket::slotAuthJobDone: " << authURL << \
endl; +                kdDebug( 14140 ) << "MSNNotifySocket::slotAuthJobDone: " << \
authURL << "(*************)" << endl;  
-                KIO::Job *job = KIO::get( authURL , false, false );
+                authURL += escape( m_account->password() );
+                KIO::Job *job = KIO::get( authURL, false, false );
 
                 m_authData = QString::null;


[prev in list] [next in list] [prev in thread] [next in thread]