[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdemultimedia/mpeglib/lib/util/render/dither2YUV
From:       Adrian Schroeter <adrian () suse ! de>
Date:       2003-08-25 13:13:50
[Download RAW message or body]

On Monday 25 August 2003 15:05, Andy Fawcett wrote:
> Hi Adrian,
>
> The following commit broke things on FreeBSD, gcc 3.2.1

uh, shit ... I will look for a different solution ...

/me wonders a bit since it is the same code as in glibc sys/cdefs.h ...

maybe it helps to use

__GNUC_PREREQ (3,3)

, but I have been told this support exists already since gcc 3.1 ...

> On Monday 25 August 2003 09:34, Adrian Schroeter wrote:
> > CVS commit by adrian:
> >
> > fix compiler with gcc 3.3.1 and later. It optimise too much and drop
> > "unused" symbols, which are only used in asm calls.
> >
> >
> >   M +19 -11    rgb2yuvdefs.h   1.2
> >
> >
> > --- kdemultimedia/mpeglib/lib/util/render/dither2YUV/rgb2yuvdefs.h
> > #1.1:1.2 @@ -19,4 +19,12 @@
> >  #define __RGB2YUVDEFS_H
> >
> > +/* gcc 3.3.1 and later optimise the "not used" (only in asm code)
> > +   symbols away. So we need to mark them as used. */
> > +#if __GNUC_PREREQ (3,1)
>
> In file included from
> /mnt/src/HEAD/kdemultimedia/mpeglib/lib/util/render/dither2YUV/rgb2yuv16.h:
>26, from
> /mnt/src/HEAD/kdemultimedia/mpeglib/lib/util/render/dither2YUV/dither2YUV.h
>:23, from
> /mnt/src/HEAD/kdemultimedia/mpeglib/lib/util/render/dither2YUV/dither2YUV.c
>pp:14:
> /mnt/src/HEAD/kdemultimedia/mpeglib/lib/util/render/dither2YUV/rgb2yuvdefs.
>h:23:5: warning: "__GNUC_PREREQ" is not defined
> /mnt/src/HEAD/kdemultimedia/mpeglib/lib/util/render/dither2YUV/rgb2yuvdefs.
>h:23:19: missing binary operator before '('

-- 

bye
adrian

**********************************************************************
Adrian Schroeter
SuSE AG, Deutschherrnstr. 15-19, 90429 Nuernberg, Germany
email: adrian@suse.de   (1945 mails already received today.)


[prev in list] [next in list] [prev in thread] [next in thread]