[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdevelop/parts/phpsupport
From:       Amilcar do Carmo Lucas <amilcar () ida ! ing ! tu-bs ! de>
Date:       2003-08-11 16:54:03
[Download RAW message or body]

CVS commit by aclu: 

Fixes a segmentation fault when closing a PHP project.
The PHPSupportPart destructor called :

delete(m_phpErrorView) and then
mainWindow()->removeView(m_phpErrorView) 

leading to a segmentation fault. 
Strange: This only happened when kdevelop was not in IDEAI-mode. 

Thanks to Sebastian (sebastian in gutweiler.net) for the patch.


  M +6 -2      phpsupportpart.cpp   1.49


--- kdevelop/parts/phpsupport/phpsupportpart.cpp  #1.48:1.49
@@ -125,6 +125,10 @@ PHPSupportPart::~PHPSupportPart()
 
     delete( phpExeProc );
-    delete( m_phpErrorView );
+
+    if(m_phpErrorView){
     mainWindow()->removeView( m_phpErrorView );
+      delete( m_phpErrorView );
+      m_phpErrorView = 0;
+    }
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]