[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeutils/klaptopdaemon [POSSIBLY UNSAFE]
From:       George Staikos <staikos () kde ! org>
Date:       2003-08-10 20:50:30
[Download RAW message or body]

On Sunday 10 August 2003 16:41, Volker Krause wrote:
> On Sunday 10 August 2003 22:21, George Staikos wrote:
> >   Don't you need root access for that?  At least this is the case here,
> > and I thought the last concensus was that root access inside
> > klaptopdaemon just doesn't work (as seen with the horrible hacks in the
> > pcmcia related stuff).
>
> Yes, same as for ACPI performance states and throttling, that's what the
> klaptop_acpi_helper is for. This is installed with setuid root for these
> purposes. This was introduced by Paul Campbell when he added the ACPI
> support some time ago, I just reused it for CPUFreq.

   This defeats the whole purpose though.  It requires root privileges because 
you don't want users to be able to do this.  Making a suid root app allows 
anyone to do it.  I would have to consider this a security hole in KDE.

> >    Furthermore there are already generic userspace tools for changing the
> > performance based on battery life.  I think it will get very confusing to
> > have two apps trying to control the system performance at the same time.
>
> I will have a look at cpufreqd as well as acpid. At least it would be a
> good idea to make klaptopdaemon aware of these tools to prevent this
> situation.

   Yes.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]