[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeutils/klaptopdaemon [POSSIBLY UNSAFE]
From:       George Staikos <staikos () kde ! org>
Date:       2003-08-10 20:21:14
[Download RAW message or body]

On Sunday 10 August 2003 16:08, Volker Krause wrote:
> On Sunday 10 August 2003 19:07, George Staikos wrote:
> > On Sunday 10 August 2003 08:37, Volker Krause wrote:
> >   Some of that code was already in that file!  cpufreq support was added
> > many months ago.  See has_cpufreq() and cpu_frequency().  We now parse
> > the cpufreq file at least twice.  cpu_frequency() actually returns a
> > string with the current cpu frequency, the maximum frequency, etc.  I
> > don't see what the new code gains except for support for other cpufreq
> > methods while duplicating an existing one, and losing the actual
> > frequency (from cpuinfo) support.
>
> The main advantage is the write support, i.e. the new code allows you to
> change the current scaling policy. And since it uses the existing [get|set]
> _system_performance() interface, it can be triggered by e.g. a low battery
> event etc. without any further work.
> I know about the exsiting code, but it is only usable for informational
> purposes. I will see how I can reduce the code duplication though.

  Don't you need root access for that?  At least this is the case here, and I 
thought the last concensus was that root access inside klaptopdaemon just 
doesn't work (as seen with the horrible hacks in the pcmcia related stuff).

   Furthermore there are already generic userspace tools for changing the 
performance based on battery life.  I think it will get very confusing to 
have two apps trying to control the system performance at the same time.  
Please have a look at cpufreqd and see if it makes more sense to have a kde 
configuration gui for that instead.  Cpufreqd is the result of several 
different approaches to this problem being merged together into a daemon.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]