[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeutils/klaptopdaemon [POSSIBLY UNSAFE]
From:       George Staikos <staikos () kde ! org>
Date:       2003-08-10 17:07:16
[Download RAW message or body]

On Sunday 10 August 2003 08:37, Volker Krause wrote:
> CVS commit by vkrause:
>
> Add support for the Linux CPUFreq interface (actually for all three of
> them).
>
>
>   M +59 -1     acpi_helper.cpp   1.11 [POSSIBLY UNSAFE: printf]
>   M +200 -4    portable.cpp   1.76

  Some of that code was already in that file!  cpufreq support was added many 
months ago.  See has_cpufreq() and cpu_frequency().  We now parse the cpufreq 
file at least twice.  cpu_frequency() actually returns a string with the 
current cpu frequency, the maximum frequency, etc.  I don't see what the new 
code gains except for support for other cpufreq methods while duplicating an 
existing one, and losing the actual frequency (from cpuinfo) support.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]