[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdepim/kmail
From:       George Staikos <staikos () kde ! org>
Date:       2003-08-10 16:43:54
[Download RAW message or body]

CVS commit by staikos: 

As I said, this code is broken.  I don't want to touch it because I don't
understand it.

However, comparing an unsigned value to see if it is negative makes no sense.

CCMAIL: kmail@kde.org


  M +1 -0      kmmsgbase.cpp   1.156


--- kdepim/kmail/kmmsgbase.cpp  #1.155:1.156
@@ -788,4 +788,5 @@ QCString KMMsgBase::encodeRFC2231String(
   while (*l)
   {
+#warning "This code is wrong.  char is unsigned on my platform."
     quote = *l < 0;
     for (i = 0; i < 17; i++) if (*l == especials[i]) quote = true;


[prev in list] [next in list] [prev in thread] [next in thread]