[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE_3_1_BRANCH: kdebase/kdm/backend
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2003-08-06 16:02:39
[Download RAW message or body]

CVS commit by ossi: 

security fix: bail out when pam_setcred fails


  M +9 -3      client.c   2.25.2.5


--- kdebase/kdm/backend/client.c  #2.25.2.4:2.25.2.5
@@ -1010,5 +1010,9 @@ StartClient (struct display *d,
 # endif
 # ifdef USE_PAM
-        pam_setcred(pamh, 0);
+        if (pam_setcred(pamh, 0) != PAM_SUCCESS) {
+            LogError("pam_setcred for %\"s failed, errno=%d\n",
+                     name, errno);
+            exit (1);
+        }
         /* pass in environment variables set by libpam and modules it called */
         pam_env = pam_getenvlist(pamh);
@@ -1268,5 +1272,7 @@ SessionExit (struct display *d, int stat
         if (pamh) {
             /* shutdown PAM session */
-            pam_setcred(pamh, PAM_DELETE_CRED);
+            if (pam_setcred(pamh, PAM_DELETE_CRED) != PAM_SUCCESS)
+                LogError("pam_setcred(DELETE_CRED) for %\"s failed, errno=%d\n",
+                         d->verify->user, errno);
             pam_close_session(pamh, 0);
             pam_end(pamh, PAM_SUCCESS);


[prev in list] [next in list] [prev in thread] [next in thread]