[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE_3_1_BRANCH: kdebase/kioslave/thumbnail
From:       Leon Bottou <leon () bottou ! org>
Date:       2003-07-21 21:26:23
[Download RAW message or body]

CVS commit by leonb: 

Backport from rev 1.16
- use QFile::encodeName(...) instead of QString::latin1().
- leak of file descriptor.


  M +5 -4      gscreator.cpp   1.9.2.3


--- kdebase/kioslave/thumbnail/gscreator.cpp  #1.9.2.2:1.9.2.3
@@ -105,5 +105,6 @@ bool GSCreator::create(const QString &pa
         while (*arg)
             ++arg;
-        *arg = path.latin1();
+        QCString fnamearg = QFile::encodeName( path );
+        *arg = fnamearg.data();
 
         execvp(gsargs[0], const_cast<char *const *>(gsargs));
@@ -163,7 +164,7 @@ bool GSCreator::create(const QString &pa
         close(input[0]);
         close(input[1]);
-        close(output[0]);
-    }
     close(output[1]);
+    }
+    close(output[0]);
 
     return ok && img.loadFromData( data );


[prev in list] [next in list] [prev in thread] [next in thread]