[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenonbeta/kopete/libkopete
From:       Martijn Klingens <klingens () kde ! org>
Date:       2003-07-14 20:11:46
[Download RAW message or body]

On Monday 14 July 2003 21:29, Matt Rogers wrote:
> On Monday 14 July 2003 02:24 pm, Will Stephenson wrote:
> > CVS commit by wstephens:
> >
> > We need to accept invalid() colours so that accounts can be set back to
> > 'no funny colour' if needed.
> >
> > FAO Tom, Bart and Matt: you no longer need to delete Color lines from
> > your kopeterc.  I've been meaning to fix this all day but this annoying
> > thing called 'work' got in the way.
> >
> >
> >   M +1 -2      kopeteaccount.cpp   1.39
> >
> >
> > --- kdenonbeta/kopete/libkopete/kopeteaccount.cpp  #1.38:1.39
> > @@ -108,5 +108,4 @@ const QColor KopeteAccount::color() cons
> >  void KopeteAccount::setColor( const QColor &color )
> >  {
> > -        if ( color.isValid() )
> >                  d->color = color;
> >  }
>
> cool. thanks! Too bad we all just can't tell work to shove it. ;)

Eh, Matt, call me stupid, but how exactly do you explain, say, this previous 
commit then? Seems like we have a choice between crash and a broken config 
now... 

-- 
Martijn

["forwarded message" (message/rfc822)]

Return-path: <kde-cvs-bounces-+klingens=kde.org@mail.kde.org>
Envelope-to: martijn@martijn.homeip.net
Delivery-date: Mon, 14 Jul 2003 04:12:36 +0200
Received: from kde.informatik.uni-kl.de ([131.246.103.200] helo=ktown.kde.org)
	by martijn.homeip.net with smtp (Exim 4.04)
	id 19bspQ-00053G-00
	for martijn@martijn.homeip.net; Mon, 14 Jul 2003 04:12:36 +0200
Received: (qmail 5174 invoked by uid 1055); 14 Jul 2003 02:12:32 -0000
Delivered-To: kde.org-klingens@kde.org
Received: (qmail 5141 invoked from network); 14 Jul 2003 02:12:29 -0000
Received: from localhost (HELO ktown.kde.org) (127.0.0.1)
  by localhost with SMTP; 14 Jul 2003 02:12:29 -0000
Received: (qmail 4718 invoked by uid 1055); 14 Jul 2003 02:12:01 -0000
Delivered-To: kde.org-kde-cvs@kde.org
Received: (qmail 4715 invoked from network); 14 Jul 2003 02:12:00 -0000
Received: from kde.suse.de (HELO office.kde.org) (213.95.15.68)
  by kde.informatik.uni-kl.de with SMTP; 14 Jul 2003 02:12:00 -0000
Received: by office.kde.org (Postfix, from userid 1079)
	id A60C59206; Mon, 14 Jul 2003 04:11:59 +0200 (CEST)
From: Matt Rogers <mattrogers@sbcglobal.net>
To: kde-cvs@kde.org
X-Commit-Directories: kdenonbeta/kopete
Content-Type: Text/Plain;
  charset="UTF-8"
Message-Id: <20030714021159.A60C59206@office.kde.org>
Date: Mon, 14 Jul 2003 04:11:59 +0200 (CEST)
X-Spam-Status: No, hits=0.0 required=5.5
	tests=none
	version=2.54
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.54 (1.174.2.17-2003-05-11-exp)
Subject: kdenonbeta/kopete/libkopete
X-BeenThere: kde-cvs@mail.kde.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: kde-cvs@kde.org
List-Id: Notifications of KDE CVS commits <kde-cvs.mail.kde.org>
List-Unsubscribe: <http://mail.kde.org/mailman/listinfo/kde-cvs>,
	<mailto:kde-cvs-request@mail.kde.org?subject=unsubscribe>
List-Post: <mailto:kde-cvs@mail.kde.org>
List-Help: <mailto:kde-cvs-request@mail.kde.org?subject=help>
List-Subscribe: <http://mail.kde.org/mailman/listinfo/kde-cvs>,
	<mailto:kde-cvs-request@mail.kde.org?subject=subscribe>
Sender: kde-cvs-bounces-+klingens=kde.org@mail.kde.org
Errors-To: kde-cvs-bounces-+klingens=kde.org@mail.kde.org
Status: R 
X-Status: N
X-KMail-EncryptionState: 
X-KMail-SignatureState: 
X-KMail-MDN-Sent: 

CVS commit by mattr: 

Fix a crash.

May I have a brown paper bag now please?


  M +2 -1      kopeteaccount.cpp   1.38


--- kdenonbeta/kopete/libkopete/kopeteaccount.cpp  #1.37:1.38
@@ -108,4 +108,5 @@ const QColor KopeteAccount::color() cons
 void KopeteAccount::setColor( const QColor &color )
 {
+        if ( color.isValid() )
         d->color = color;
 }




[prev in list] [next in list] [prev in thread] [next in thread]