[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kcontrol/filetypes
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2003-07-10 6:10:30
[Download RAW message or body]

CVS commit by firebaugh: 

Don't crash when adding a service to the empty list. CCMAIL: 61023-done@bugs.kde.org


  M +9 -6      kservicelistwidget.cpp   1.17


--- kdebase/kcontrol/filetypes/kservicelistwidget.cpp  #1.16:1.17
@@ -225,4 +225,11 @@ void KServiceListWidget::addService()
   }
 
+  // if None is the only item, then there currently is no default
+  if (servicesLB->text(0) == i18n("None")) {
+      servicesLB->removeItem(0);
+      servicesLB->setEnabled(true);
+  }
+  else
+  {
   // check if it is a duplicate entry
   for (unsigned int index = 0; index < servicesLB->count(); index++)
@@ -230,10 +237,6 @@ void KServiceListWidget::addService()
         == service->desktopEntryPath())
       return;
-
-  // if None is the only item, then there currently is no default
-  if (servicesLB->text(0) == i18n("None")) {
-      servicesLB->removeItem(0);
-      servicesLB->setEnabled(true);
   }
+
   QString desktopPath = service->desktopEntryPath();
 


[prev in list] [next in list] [prev in thread] [next in thread]