[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE_3_1_BRANCH: kdelibs/khtml/xml
From:       David Faure <faure () kde ! org>
Date:       2003-06-30 23:06:56
[Download RAW message or body]

CVS commit by faure: 

Backport from HEAD: don't crash importNode when giving it a null node.
(Found thanks to PMK's regression testing framework)


  M +8 -1      dom_docimpl.cpp   1.200.2.8


--- kdelibs/khtml/xml/dom_docimpl.cpp  #1.200.2.7:1.200.2.8
@@ -354,4 +354,11 @@ NodeImpl *DocumentImpl::importNode(NodeI
 {
         NodeImpl *result = 0;
+
+    // Not mentioned in spec: throw NOT_FOUND_ERR if evt is null
+    if (!importedNode) {
+        exceptioncode = DOMException::NOT_FOUND_ERR;
+        return 0;
+    }
+
 
         if(importedNode->nodeType() == Node::ELEMENT_NODE)


[prev in list] [next in list] [prev in thread] [next in thread]