[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenonbeta/kopete/libkopete
From:       Richard Smith <kde () metafoo ! co ! uk>
Date:       2003-06-29 1:22:16
[Download RAW message or body]

CVS commit by lilachaze: 

Made writing of XML plugin data slightly more sane. I can no longer
reproduce the account-data-randomly-being-lost bug, but I'm by no means sure
it's fixed.


  M +7 -6      kopeteplugindataobject.cpp   1.7


--- kdenonbeta/kopete/libkopete/kopeteplugindataobject.cpp  #1.6:1.7
@@ -67,7 +67,5 @@ QString KopetePluginDataObject::pluginDa
 const QValueList<QDomElement> KopetePluginDataObject::toXML()
 {
-        QDomDocument pluginData;
         QValueList<QDomElement> pluginNodes;
-        pluginData.appendChild( pluginData.createElement( \
QString::fromLatin1("plugin-data")) );  
         if( !m_pluginData.isEmpty() )
@@ -76,5 +74,6 @@ const QValueList<QDomElement> KopetePlug
                 for( pluginIt = m_pluginData.begin(); pluginIt != \
m_pluginData.end(); ++pluginIt )  {
-                        QDomElement pluginElement = pluginData.createElement( \
QString::fromLatin1("plugin-data") ); +                        QDomElement \
pluginElement; +                        pluginElement.setTagName( \
                QString::fromLatin1("plugin-data") );
                         pluginElement.setAttribute( \
QString::fromLatin1("plugin-id"), pluginIt.key()  );  
@@ -82,11 +81,13 @@ const QValueList<QDomElement> KopetePlug
                         for( it = pluginIt.data().begin(); it != \
pluginIt.data().end(); ++it )  {
-                                QDomElement pluginDataField = \
pluginData.createElement( QString::fromLatin1("plugin-data-field") ); +               \
QDomElement pluginDataField; +                                \
                pluginDataField.setTagName( QString::fromLatin1("plugin-data-field") \
                );
                                 pluginDataField.setAttribute( \
                QString::fromLatin1("key"), it.key()  );
-                                pluginDataField.appendChild( \
pluginData.createTextNode(  it.data()  ) ); +                                QDomText \
pluginDataValue; +                                pluginDataValue.setData( it.data() \
); +                                pluginDataField.appendChild( pluginDataValue );
                                 pluginElement.appendChild( pluginDataField );
                         }
 
-                        pluginData.documentElement().appendChild( pluginElement );
                         pluginNodes.append( pluginElement );
                 }


[prev in list] [next in list] [prev in thread] [next in thread]