[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdecore
From:       Benjamin Meyer <ben () meyerhome ! net>
Date:       2003-06-18 14:20:29
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 18 June 2003 5:22 am, Oswald Buddenhagen wrote:
> On Wed, Jun 18, 2003 at 06:15:45AM +0200, Benjamin Meyer wrote:
> > CVS commit by bmeyer:
> >
> > Just being safe :)
> >
> > --- kdelibs/kdecore/kautoconfig.cpp  #1.32:1.33
> > @@ -136,5 +136,5 @@ bool KAutoConfig::retrieveSettings(bool
> > -  QWidget *widget;
> > +  QWidget *widget = 0;
> >    while ( (widget = it.current()) != 0 ) {
>
> this is not safe, but major nonsense. if you're lucky, the compiler will
> simply remove the assignment; if not, you have 1-2 _totally_ useless
> instructions in the code.

on gcc2 it crashed, on gcc3 it didn't...  I havn't a clue why it would crash, 
but this fixed it...

- -Benjamin Meyer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+8HUu1rZ3LTw38vIRArwHAKCoH9ui7uB2D2ZGCMDLz/zOCiUMSQCeIMr4
w9OkIAfbSbkBg91vgLhF2EE=
=Kf4L
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]