[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/libkonq
From:       David Faure <dfaure () trolltech ! com>
Date:       2003-06-16 0:02:47
[Download RAW message or body]

On Sunday 15 June 2003 19:29, Sashmit B. Bhaduri wrote:
> David Faure wrote:
> > I didn't test, but isn't this the menu item that appeared when right-clicking
> > a directory in the sidebar (the directory tree module) ?
> > If that's the case, then please revert or fix otherwise, this menu item is
> > VERY much needed.
> 
> Oh, whopps. I forgot about dirtrees. I reverted it.

Thanks.
Looks like we need a new concept in this class, to differenciate between
"a subdir in an iconview" and "a subdir in the sidebar dirtree"...........
or in the treeview, for that matter.

I guess the main difference is that the new subdir would be visible in a tree view,
and not visible in an iconview or flat listview. Maybe something like
KonqPopupMenu::setDirectoryViewIsHierarchical(bool) (a separate method
since we can't add a constructor argument in a BC way).
If this is called with "true" (default would be false), by the sidebar and the treeview,
then the code you removed and readded, can check for that bool.
What do you think?

-- 
David FAURE, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html
[prev in list] [next in list] [prev in thread] [next in thread]