From kde-commits Sat May 31 21:20:58 2003 From: George Staikos Date: Sat, 31 May 2003 21:20:58 +0000 To: kde-commits Subject: Re: kdemultimedia X-MARC-Message: https://marc.info/?l=kde-commits&m=105441611931216 On Thursday 29 May 2003 19:56, Arnold Krille wrote: > On Wednesday 28 May 2003 06:52, George Staikos wrote: > > CVS commit by staikos: > > more dynamic_cast fixes/notes > > M +1 -0 arts/modules/effects/kstereovolumecontrolgui_impl.cpp > > 1.3 > > The line you are asking shouldn't fail since the mapper is in the same > header and object-file as the effect. But perhaps you could clearify this > for me? I am not a good programmer :( dynamic_cast<> can always return 0L. You must be prepared to handle this case. I'm sure in this case it *shouldn't* but that doesn't change the fact that it could, and if the code is changed in the future to add another incompatible object it could eventually legitimately fail. -- George Staikos KDE Developer http://www.kde.org/ Staikos Computing Services Inc. http://www.staikos.net/