[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdecore
From:       George Staikos <staikos () kde ! org>
Date:       2003-05-22 14:06:27
[Download RAW message or body]

On Wednesday 21 May 2003 06:24, Nicolas Hadacek wrote:
> On Wednesday 21 May 2003 09:10 pm, George Staikos wrote:
> > On Wednesday 21 May 2003 22:43, Nicolas Hadacek wrote:
> > > CVS commit by hadacek:
> > >
> > > slightly extend KConfig/KConfigINIBackEnd API
> >
> >   Why did you put a FILE* in the public API for kconfigbackend?
>
> first of all (nitpicking) it is not in the public API but in the protected
> API. I did just move a function from the cpp file to the header and I think
> that KConfigINIBackEnd uses a file stream for efficiency reasons.

   Protected is just a special case of public.

> Also since I am using KConfigRawBackEnd (see attachement) on a locked file,
> I think that I cannot fclose a file stream without losing the lock... so
> using a file descriptor in the API is not really an option for this use.
>
> If you find another solution, I'd be glad to hear about it...

   Perhaps some documentation for those functions would be a good idea.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]