[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdegames/kmines
From:       Nicolas Hadacek <hadacek () kde ! org>
Date:       2003-05-01 4:20:05
[Download RAW message or body]

CVS commit by hadacek: 

fix assert in custom dialog (thanks to Albert Astals Cid)


  M +4 -1      CHANGELOG   1.67
  M +7 -6      dialogs.cpp   1.74
  M +3 -2      dialogs.h   1.53


--- kdegames/kmines/CHANGELOG  #1.66:1.67
@@ -1,5 +1,8 @@
 2.1.8 (17 January 2003) [CVS 3.2 devel]
- * config button in highscores dialog
+ * configure button in highscores dialog
  * notifications
+
+2.1.7d (30 April 2003) [ KDE 3.1.2 stable]
+ * fix assert in custom dialog [reported by Albert Astals Cid]
 
 2.1.7c (17 January 2003) [ KDE 3.1.1 stable]

--- kdegames/kmines/dialogs.cpp  #1.73:1.74
@@ -111,5 +111,5 @@ void DigitalClock::setCheating()
 //-----------------------------------------------------------------------------
 CustomConfig::CustomConfig()
-    : KConfigWidget(i18n("Custom Game"), "configure")
+    : KConfigWidget(i18n("Custom Game"), "configure"), _block(false)
 {
         QVBoxLayout *top = new QVBoxLayout(this, KDialog::spacingHint());
@@ -149,4 +149,5 @@ CustomConfig::CustomConfig()
 void CustomConfig::updateNbMines()
 {
+    if (_block) return;
     Level l(_width->value().toUInt(), _height->value().toUInt(),
             _mines->value().toUInt());
@@ -160,10 +161,10 @@ void CustomConfig::updateNbMines()
 void CustomConfig::typeChosen(int i)
 {
-    blockSignals(true);
+    _block = true;
     Level level((Level::Type)i);
     _width->setValue(level.width());
     _height->setValue(level.height());
     _mines->setValue(level.nbMines());
-    blockSignals(false);
+    _block = false;
     updateNbMines();
 }

--- kdegames/kmines/dialogs.h  #1.52:1.53
@@ -87,4 +87,5 @@ class CustomConfig : public KConfigWidge
 
  private:
+    bool _block;
         KConfigItem *_width, *_height, *_mines;
     KComboBox   *_gameType;


[prev in list] [next in list] [prev in thread] [next in thread]