[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE_3_1_BRANCH: kdebase/kioslave/smtp
From:       Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date:       2003-04-30 21:07:52
[Download RAW message or body]

CVS commit by mutz: 

revert commit "from HEAD: [SECURITY] Don't silently bypass authentication if we're \
asked to use it and the server doesn't support any mechanisms." since doing it right \
requires string changes


  M +3 -4      smtp.cc   1.100.2.8


--- kdebase/kioslave/smtp/smtp.cc  #1.100.2.7:1.100.2.8
@@ -717,7 +717,6 @@ bool SMTPProtocol::Authenticate()
   // Choose available method from what the server has given us in  its greeting
   QStringList sl = QStringList::split(' ', m_sAuthConfig);
-  // If the server doesn't support/require authentication, we ignore
-  // it (unless we're asked not to by metadata)
-  if (sl.isEmpty() && metaData("sasl").isEmpty())
+  // If the server doesn't support/require authentication, we ignore it
+  if (sl.isEmpty())
     return true;
   QStrIList strList;


[prev in list] [next in list] [prev in thread] [next in thread]