[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeutils/kdepasswd/userinfo
From:       Ravikiran Rajagopal <ravi () ee ! eng ! ohio-state ! edu>
Date:       2003-04-22 16:42:33
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Why is this necessary? Does some sort of idle time processing happen after the 
object is deleted from the stack?

Benjamin Meyer wrote:

> CVS commit by bmeyer:
> 
> More segfault fixes
> 
> 
>   M +10 -10    userinfo_chface.cpp   1.4
> 
> 
> --- kdeutils/kdepasswd/userinfo/userinfo_chface.cpp  #1.3:1.4
> @@ -137,17 +137,17 @@ void KUserInfoChFaceDlg::slotGetCustomIm
>    QCheckBox* checkWidget = new QCheckBox( i18n("&Save copy in custom
>    faces folder for future use"), 0 );
>  
> -  KFileDialog dlg( QDir::homeDirPath(), KImageIO::pattern(
> KImageIO::Reading ),
> +  KFileDialog *dlg = new KFileDialog( QDir::homeDirPath(),
> KImageIO::pattern( KImageIO::Reading ),
>                    this, 0, true, checkWidget);
>  
> -  dlg.setOperationMode( KFileDialog::Opening );
> -  dlg.setCaption( i18n("Choose Image") );
> -  dlg.setMode( KFile::File | KFile::LocalOnly );
> -
> -  KImageFilePreview ip( &dlg );
> -  dlg.setPreviewWidget( &ip );
> -  if (dlg.exec() == QDialog::Accepted)
> -      addCustomPixmap( dlg.selectedFile(), checkWidget->isChecked() );
> +  dlg->setOperationMode( KFileDialog::Opening );
> +  dlg->setCaption( i18n("Choose Image") );
> +  dlg->setMode( KFile::File | KFile::LocalOnly );
>  
> -  delete checkWidget;
> +  KImageFilePreview *ip = new KImageFilePreview( dlg );
> +  dlg->setPreviewWidget( ip );
> +  if (dlg->exec() == QDialog::Accepted)
> +      addCustomPixmap( dlg->selectedFile(), checkWidget->isChecked() );
> +  // Because we give it a parent we have to close it ourselves.
> +  dlg->close(true);
>  }
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+pXEBbI8Y8y0oVXcRAuGKAKCI55S4A3PP7r6oTAcu0H7RBAHMLACfQE72
tT9uu5tkvem0yH7zR5aN3qk=
=y4K2
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]