[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenonbeta/kopete/libkopete/private
From:       Carsten Pfeiffer <carpdjih () mailbox ! tu-berlin ! de>
Date:       2003-04-22 11:18:35
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----

On Monday 21 April 2003 21:47, Olivier Goffart wrote:
> --- kdenonbeta/kopete/libkopete/private/kopetexmllogger.cpp  #1.7:1.8
> @@ -30,7 +30,17 @@
> void KopeteXMLLogger::logMessage( const KopeteMessage &msg )
> {
> +        //FIXME: this is totaly broken.
> +        // 1) the metacontact dysplayname can change, this is not a good
> name for the file +        // 2) the contact can be moved to another
> metacontact
> +        // 3) Je n'aime pas le principe de ce KopeteLogger  (forget it)
> +        //
> +        //The main problem is the perenity, i want to be able to find what
> i said two years ago! +        //i have to search a lot of location 1) my
> MS windows log.  this is verry easy because they are in plain text, a grep
> is sufficient +        // 2) kopete 0.5 logs , 3) kopete 0.6  theses one
> are a little more difficult because they are stored in xml, but this is not
> a problem +        // 4) recent logs, and now, i lost a lot of data bacause
> kopete didn't log outgoing messages and how to retreive it in two years?
> not sure i can +        //                      - Olivier
> +
>          KopeteContactPtrList members = msg.to();
> -        KopeteMetaContact *m = 0L;
> -        m = members.first()->metaContact();
> +        KopeteMetaContact *m = (msg.direction() == KopeteMessage::Inbound)
> ? msg.from()->metaContact() : members.first()->metaContact();

A while ago I did exactly the same fix, but was corrected by Jason. He said 
that KopeteMessages should have the same to() independent of whether it's an 
incoming or outgoing message. So plugin has to ensure that. 

Too bad that's nowhere documented and the API doesn't enforce this either.

I agree with all the format troubles, I'd like to have my old icq histories 
back as well.

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPqUlC6WgYMJuwmZtAQHUuwf6A0ikm+jYWpo/xoRR4uXO1b4XUpfQF/8T
8YgWmavo9gISOzK/ZH9FwBrr+8caaEEp+2Z90oXxgrW2VnQB2yLpNL1KaBCm+LbS
MSk+viIJXYam0nkCwhbDWNDmDu/6pWUZjToOE3nyarWA+Guc/9Oz97+jCp86dGyK
X9OjSyf2sXa2fO3Vjh03VohEFa3dSZq7yOcUDnNfzSBlUrcEcxxB8k8lOpIcgSzL
LwS+Zrf20NT6WSggTZcN+1+2FbOcX+dzG+kVoSieU/WzVwx19BlKnL0dDLJdVi+1
9wvg+SsflBRGLeWqo6NuUg1e5eiRSqCSlD/792zQrFju6icwfxKnxA==
=fFB8
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]