[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kioslave/smtp
From:       Stephan Kulow <coolo () kde ! org>
Date:       2003-04-03 18:16:18
[Download RAW message or body]

Am Thursday 03 April 2003 10:22 schrieb Marc Mutz:
> CVS commit by mutz:
>
> IDNA compatibility
>
>
>   M +6 -3      smtp.cc   1.110
>
>
> --- kdebase/kioslave/smtp/smtp.cc  #1.109:1.110
> @@ -70,4 +70,5 @@
>  #include <kio/kdesasl.h>
>  #include <klocale.h>
> +#include <kidna.h>
>
>  #include "smtp.h"
> @@ -591,5 +592,6 @@ bool SMTPProtocol::smtp_open(const QStri
>    }
>
> -  if (!command(("EHLO " + m_hostname), false, ehloByteArray.data(),
> DEFAULT_EHLO_BUFFER - 1)) +  if (!command( "EHLO " +
> KIDNA::toAsciiCString(m_hostname),
> +                false, ehloByteArray.data(), DEFAULT_EHLO_BUFFER - 1))

Careful! KIDNA returns QCString(0) when no libidn is found. I still wonder why
this is a runtime check without any hint from configure, but at least this 
code will fail in strange ways without an error message that points in the 
right direction.

Waldo, perhaps KIDNA::toAsciiCString shouldn't return null, but something like
a string that is connected remotely with the original (e.g. removing all 
non-ascii characters)?

Greetings, Stephan

-- 
Pace, Peace, Paix, Paz, Frieden, Pax, Pokój

[prev in list] [next in list] [prev in thread] [next in thread]