[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenonbeta/kopete/libkopete/ui
From:       Martijn Klingens <klingens () kde ! org>
Date:       2003-03-25 19:51:40
[Download RAW message or body]

CVS commit by mklingens: 

Make the KJanusWidget crash fix conditional; add some more docs on the subject.

Thanks to
CCMAIL: Ravikiran Rajagopal <ravi@ee.eng.ohio-state.edu>
for the explanation.


  M +9 -2      configmodule.cpp   1.14


--- kdenonbeta/kopete/libkopete/ui/configmodule.cpp  #1.13:1.14
@@ -55,7 +55,14 @@ ConfigModule::ConfigModule(const QString
 ConfigModule::~ConfigModule()
 {
-        // TODO When kdialogbase is fixed, delete the parent QFrame, and
-        // all traces of the related page
+#if (QT_VERSION>=0x030005 && QT_VERSION<0x030102) && KDE_VERSION<0x0302000
+        // Due to a bug in Qt 3.1 and 3.1.1 no close events are sent to hidden
+        // widgets, causing the KJanusWidget to crash. This workaround is
+        // rather intrusive and should be used only in the affected versions
+        // to avoid hard to track bugs in the future. KDE HEAD (to become 3.2)
+        // has a workaround for this problem, and additionally it's fixed in
+        // Qt 3.1.2.
         kapp->sendPostedEvents();
+#endif
+
         PreferencesDialog::preferencesDialog()->remove(this);
 }


[prev in list] [next in list] [prev in thread] [next in thread]