[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kioslave/fish
From:       Willy De la Court <Willy.DelaCourt () pandora ! be>
Date:       2003-03-23 16:22:25
[Download RAW message or body]

CVS commit by willy: 

Security fix tempfile should not be world readable
bugfix write to the file not the command

CCMAIL:jwalt-kde@garni.ch


  M +1 -1      fish.cpp   1.25
  M +1 -1      fish.pl   1.7


--- kdebase/kioslave/fish/fish.cpp  #1.24:1.25
@@ -224,5 +224,5 @@ const struct fishProtocol::fish_info fis
       0 },
     { ("EXEC"), 2,
-      ("eval %1 < /dev/null > %2 2>&1; echo \"#RESULT# $?\" >> %2;"),
+      ("touch %2; chmod 600 %2; eval %1 < /dev/null > %2 2>&1; echo \"#RESULT# $?\" >> %2"),
       0 }
 };

--- kdebase/kioslave/fish/fish.pl  #1.6:1.7
@@ -196,5 +196,5 @@
     };
     /^EXEC\s+((?:\\.|[^\\])*?)\s+((?:\\.|[^\\])*?)\s*$/ && do {
-        system("eval $1 < /dev/null > $2 2>&1; echo \"#RESULT# $?\" >> $1;");
+        system("touch $2; chmod 600 $2; eval $1 < /dev/null > $2 2>&1; echo \"#RESULT# $?\" >> $2;");
         print "### 200\n";
         next;


[prev in list] [next in list] [prev in thread] [next in thread]