[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/konqueror/sidebar
From:       George Staikos <staikos () kde ! org>
Date:       2003-03-11 13:59:55
[Download RAW message or body]

CVS commit by staikos: 

Save 6 QString constructions and as many as 6 string comparisons.


  M +16 -9     sidebar_widget.cpp   1.88


--- kdebase/konqueror/sidebar/sidebar_widget.cpp  #1.87:1.88
@@ -916,15 +916,22 @@ void Sidebar_Widget::enableAction( const
         if (sender()->parent()->isA("ButtonInfo"))
         {
-                ButtonInfo *btninfo=static_cast<ButtonInfo*>(sender()->parent());
-//              ButtonInfo *btninfo=dynamic_cast<ButtonInfo*>(sender()->parent());
+                ButtonInfo *btninfo = static_cast<ButtonInfo*>(sender()->parent());
                 if (btninfo)
                 {
-                        if (QString(name)=="copy") btninfo->copy=enabled;
-                        if (QString(name)=="cut") btninfo->cut=enabled;
-                        if (QString(name)=="paste") btninfo->paste=enabled;
-                        if (QString(name)=="trash") btninfo->trash=enabled;
-                        if (QString(name)=="del") btninfo->del=enabled;
-                        if (QString(name)=="shred") btninfo->shred=enabled;
-                        if (QString(name)=="rename") btninfo->rename=enabled;
+                        QString n(name);
+                        if (n == "copy")
+                                btninfo->copy = enabled;
+                        else if (n == "cut")
+                                btninfo->cut = enabled;
+                        else if (n == "paste")
+                                btninfo->paste = enabled;
+                        else if (n == "trash")
+                                btninfo->trash = enabled;
+                        else if (n == "del")
+                                btninfo->del = enabled;
+                        else if (n == "shred")
+                                btninfo->shred = enabled;
+                        else if (n == "rename")
+                                btninfo->rename = enabled;
                 }
         }


[prev in list] [next in list] [prev in thread] [next in thread]