[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenonbeta/kopete/protocols/irc/libkirc
From:       Martijn Klingens <klingens () kde ! org>
Date:       2003-03-09 20:09:34
[Download RAW message or body]

On Sunday 09 March 2003 20:52, James Grant wrote:
> I would think that creating the Iterator when it isnt required would cost
> more than the if statement.

That's not the issue though.

Your if() makes the code a lot less readable, so if the performance loss is 
neglectible (and it is in this case) I think it's wrong to add this 
optimization at all. This is not a hot code path after all.

Optimize only where it matters, not everywhere it's possible.

-- 
Martijn

[prev in list] [next in list] [prev in thread] [next in thread]