[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenonbeta/kopete/protocols/irc/libkirc
From:       James Grant <topace () lightbox ! org>
Date:       2003-03-09 19:52:15
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I would think that creating the Iterator when it isnt required would cost more 
than the if statement. ... maybe not with the two .contains , that should be 
a regexp, but now Jason is going to move it to irccontact::slotSendMsg 
anyways, so this code will dissappear :p

Back to homework I go... that was my coding stint for the week :p

 James


On March 9, 2003 02:56 pm, Martijn Klingens wrote:
> On Sunday 09 March 2003 20:35, James Grant wrote:
> > Allow sending multi-line messages (which just get split into separate
> > messages)
>
> Is QStringList::split() that slow that you need two separate code paths?
> Why not simply split right away and iterate regardless of whether the
> message actually contains newlines?

- -- 
James Grant
topace@lightbox.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (GNU/Linux)

iD8DBQE+a5tvV7tGVeQW9pcRAnAcAJ4msy2yrcG9d9nTwE1WdSFQ9QN5egCfe424
1uN8gDEI9rFMBHTGTqRe4lo=
=R5CU
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]